Skip to content

Add 'Webapi.Dom.MediaQueryList' #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add 'Webapi.Dom.MediaQueryList' #138

merged 1 commit into from
Feb 20, 2025

Conversation

mvaled
Copy link
Contributor

@mvaled mvaled commented Feb 13, 2025

TheSpyder
TheSpyder approved these changes Feb 20, 2025
View reviewed changes
Copy link
Owner

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could perhaps see a case for adding bindings for the listeners, but this is still a good addition. Thank you!

@TheSpyder TheSpyder merged commit 84d586f into TheSpyder:main Feb 20, 2025
1 check passed
@mvaled mvaled deleted the add-media-query-list branch February 22, 2025 02:04
@mvaled
Copy link
Contributor Author

mvaled commented Feb 22, 2025

I could perhaps see a case for adding bindings for the listeners, but this is still a good addition. Thank you!

Do you mean bindings for addListener and removeListener? I didn't add them because they are marked as deprecated.

@TheSpyder
Copy link
Owner

ah, I didn't notice that was now a little trash icon instead of a deprecated tag on the link. Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaled @TheSpyder